Skip to content

Conversation

Noratrieb
Copy link
Member

@Noratrieb Noratrieb commented Oct 5, 2025

This will make -Zbuild-std automatically build the right crates, notably not building std by default, which will both be useful for users and also fix the build for https://does-it-build.noratrieb.dev, which currently tries to build std: http://localhost:3000/build?nightly=2025-07-12&target=avr-none&mode=std.

cc @Patryk27 but I don't think this necessarily needs your approval

This will make `-Zbuild-std` automatically build the right crates, notably not building `std` by default, which will both be useful for users and also fix the build for https://does-it-build.noratrieb.dev.
@rustbot
Copy link
Collaborator

rustbot commented Oct 5, 2025

These commits modify compiler targets.
(See the Target Tier Policy.)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 5, 2025
@rustbot
Copy link
Collaborator

rustbot commented Oct 5, 2025

r? @SparrowLii

rustbot has assigned @SparrowLii.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Copy link
Member

@jieyouxu jieyouxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jieyouxu
Copy link
Member

jieyouxu commented Oct 5, 2025

r? jieyouxu @bors r+ rollup

@bors
Copy link
Collaborator

bors commented Oct 5, 2025

📌 Commit 9ccaf08 has been approved by jieyouxu

It is now in the queue for this repository.

@rustbot rustbot assigned jieyouxu and unassigned SparrowLii Oct 5, 2025
@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 5, 2025
bors added a commit that referenced this pull request Oct 5, 2025
Rollup of 5 pull requests

Successful merges:

 - #144908 (Fix doctest output json)
 - #147262 (Make #[link="dl"] an FCW rather than an error)
 - #147364 (update autodiff testcases)
 - #147367 (Trivial code cleanup in resolve)
 - #147369 (Fill out AVR target metadata)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 21b5d6b into rust-lang:master Oct 5, 2025
10 checks passed
rust-timer added a commit that referenced this pull request Oct 5, 2025
Rollup merge of #147369 - Noratrieb:avr-metadata, r=jieyouxu

Fill out AVR target metadata

This will make `-Zbuild-std` automatically build the right crates, notably not building `std` by default, which will both be useful for users and also fix the build for https://does-it-build.noratrieb.dev, which currently tries to build std: http://localhost:3000/build?nightly=2025-07-12&target=avr-none&mode=std.

cc `@Patryk27` but I don't think this necessarily needs your approval
@rustbot rustbot added this to the 1.92.0 milestone Oct 5, 2025
@Noratrieb Noratrieb deleted the avr-metadata branch October 5, 2025 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants